Page MenuHomePhabricator

When users choose a default project icon, make a permanent file
ClosedPublic

Authored by epriestley on Jul 11 2016, 3:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2024, 11:15 AM
Unknown Object (File)
Feb 16 2024, 10:52 AM
Unknown Object (File)
Feb 6 2024, 7:49 PM
Unknown Object (File)
Feb 3 2024, 11:21 AM
Unknown Object (File)
Jan 7 2024, 5:17 AM
Unknown Object (File)
Dec 28 2023, 12:06 AM
Unknown Object (File)
Dec 27 2023, 8:27 AM
Unknown Object (File)
Dec 21 2023, 3:39 PM
Subscribers
None

Details

Summary

Fixes T10907. As written, this workflow will incorrectly reuse a temporary file if one exists.

Instead, make a new permanent file.

(Storage is still shared, so this usually will not actually create a copy of the file's data.)

Test Plan
  • Set a project's icon by clicking first button in "Use Picture" row.
  • Before patch: temporary image was reused.
  • After patch: new permanent file is generated.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When users choose a default project icon, make a permanent file.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2016, 3:27 PM
This revision was automatically updated to reflect the committed changes.