Page MenuHomePhabricator

When users choose a default project icon, make a permanent file
ClosedPublic

Authored by epriestley on Jul 11 2016, 3:25 PM.
Tags
None
Referenced Files
F18107720: D16270.diff
Mon, Aug 11, 2:37 AM
F18093317: D16270.id39142.diff
Thu, Aug 7, 5:29 PM
F17929625: D16270.diff
Wed, Jul 30, 5:18 PM
F17868256: D16270.id.diff
Mon, Jul 28, 7:27 AM
F17859954: D16270.diff
Sun, Jul 27, 9:18 PM
Unknown Object (File)
Jun 18 2025, 6:41 AM
Unknown Object (File)
Jun 17 2025, 9:12 PM
Unknown Object (File)
May 27 2025, 11:20 AM
Subscribers
None

Details

Summary

Fixes T10907. As written, this workflow will incorrectly reuse a temporary file if one exists.

Instead, make a new permanent file.

(Storage is still shared, so this usually will not actually create a copy of the file's data.)

Test Plan
  • Set a project's icon by clicking first button in "Use Picture" row.
  • Before patch: temporary image was reused.
  • After patch: new permanent file is generated.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When users choose a default project icon, make a permanent file.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2016, 3:27 PM
This revision was automatically updated to reflect the committed changes.