Page MenuHomePhabricator

When users choose a default project icon, make a permanent file
ClosedPublic

Authored by epriestley on Jul 11 2016, 3:25 PM.
Tags
None
Referenced Files
F18808237: D16270.id.diff
Oct 19 2025, 5:40 AM
F18806735: D16270.diff
Oct 18 2025, 9:19 PM
F18791247: D16270.diff
Oct 16 2025, 7:33 AM
F18651633: D16270.id39137.diff
Sep 21 2025, 4:53 AM
F18644112: D16270.id39142.diff
Sep 19 2025, 4:19 AM
F18626451: D16270.id.diff
Sep 16 2025, 1:17 AM
F18617732: D16270.diff
Sep 14 2025, 10:00 PM
F18611418: D16270.diff
Sep 14 2025, 7:13 AM
Subscribers
None

Details

Summary

Fixes T10907. As written, this workflow will incorrectly reuse a temporary file if one exists.

Instead, make a new permanent file.

(Storage is still shared, so this usually will not actually create a copy of the file's data.)

Test Plan
  • Set a project's icon by clicking first button in "Use Picture" row.
  • Before patch: temporary image was reused.
  • After patch: new permanent file is generated.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When users choose a default project icon, make a permanent file.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2016, 3:27 PM
This revision was automatically updated to reflect the committed changes.