Page MenuHomePhabricator
Differential D16270

When users choose a default project icon, make a permanent file
ClosedPublic
Actions

Authored by epriestley on Jul 11 2016, 3:25 PM.
Tags
None
Referenced Files
F15412669: D16270.id39137.diff
Wed, Mar 19, 2:17 PM
F15408240: D16270.id.diff
Tue, Mar 18, 9:50 PM
F15386248: D16270.id39137.diff
Sat, Mar 15, 12:14 AM
F15336476: D16270.diff
Sat, Mar 8, 7:03 PM
Unknown Object (File)
Feb 23 2025, 4:04 PM
Unknown Object (File)
Feb 16 2025, 7:06 AM
Unknown Object (File)
Feb 9 2025, 1:59 AM
Unknown Object (File)
Feb 9 2025, 1:59 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10907: Older project's icon changes back after a few days
Commits
rP830f3eb8f803: When users choose a default project icon, make a permanent file
Summary

Fixes T10907. As written, this workflow will incorrectly reuse a temporary file if one exists.

Instead, make a new permanent file.

(Storage is still shared, so this usually will not actually create a copy of the file's data.)

Test Plan
  • Set a project's icon by clicking first button in "Use Picture" row.
  • Before patch: temporary image was reused.
  • After patch: new permanent file is generated.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39137.Jul 11 2016, 3:25 PM
epriestley retitled this revision from to When users choose a default project icon, make a permanent file.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10907: Older project's icon changes back after a few days.
epriestley mentioned this in D16243: Ensure files live as long as intended..Jul 11 2016, 3:26 PM
chad accepted this revision.Jul 11 2016, 3:27 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2016, 3:27 PM
Closed by commit rP830f3eb8f803: When users choose a default project icon, make a permanent file (authored by epriestley, committed by epriestley). · Explain WhyJul 11 2016, 4:24 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10907: Older project's icon changes back after a few days.Jul 11 2016, 4:24 PM

Revision Contents
Changeset List

PathSize
src/
applications/
files/
controller/
2 lines

Diff 39142

View Options

src/applications/files/controller/PhabricatorFileComposeController.php

Loading...
Phabricator · Built by Phacility