Make Phame Header and Profile Image Transactional
ClosedPublic
Actions

Authored by chad on Jul 1 2016, 5:50 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T9360: Unbeta Phame

Commits

rPf26374241ab1: Make Phame Header and Profile Image Transactional

Summary

Ref T9360. This makes these transactional.

Test Plan

Set new header, delete header. Set new profile image, reset profile image.

Diff Detail

Repository

rP Phabricator

Branch

phame-4 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12888
Build 16437: Run Core Tests
Build 16436: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39010.Jul 1 2016, 5:50 PM

chad retitled this revision from to Make Phame Header and Profile Image Transactional.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9360: Unbeta Phame.

Herald added a subscriber: Korvin. · View Herald TranscriptJul 1 2016, 5:50 PM

errant save

Minor nitpick that doesn't really matter: ideally, you should let ApplicationTransactionEditor handle the $file->attachToObject(...) call, by implementing extractFilePHIDsFromCustomTransaction().

However, this won't change anything and it's an easier fix when this moves to ModularTransactions so it's 100% fine to just leave it as-is for now.

src/applications/phame/storage/PhameBlogTransaction.php
186	Should these be renderHandleLink()?

This revision is now accepted and ready to land.Jul 1 2016, 6:06 PM

chad added inline comments.Jul 1 2016, 6:16 PM

src/applications/phame/storage/PhameBlogTransaction.php
186	I'm breaking something, can't figure it out. Transaction ("PHID-XACT-BLOG-dtq3uozqaazuqdx", of type "phame.blog.profile.image") requires a handle ("PHID-FILE-d6y2dbp2ikdr5zamxxk7") that it did not load.