Page MenuHomePhabricator
Differential D16201

When all actions in a submenu are disabled, disable the submenu header
ClosedPublic
Actions

Authored by epriestley on Jun 30 2016, 5:24 PM.
Tags
None
Referenced Files
F18094084: D16201.diff
Thu, Aug 7, 9:57 PM
F18092815: D16201.id.diff
Thu, Aug 7, 1:23 PM
F18043772: D16201.id.diff
Sun, Aug 3, 6:23 AM
F17940440: D16201.id38967.diff
Thu, Jul 31, 4:22 AM
F17915544: D16201.diff
Tue, Jul 29, 8:47 PM
F17914934: D16201.id38969.diff
Tue, Jul 29, 7:53 PM
F17899865: D16201.diff
Tue, Jul 29, 8:48 AM
Unknown Object (File)
Jul 3 2025, 11:01 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11240: Expandable menus are not greyed out, even if all options are not useable
Commits
rP7574f8dcf51a: When all actions in a submenu are disabled, disable the submenu header
Summary

Fixes T11240. Also simplify things a little and share a bit more code.

Test Plan
  • Viewed revisions and tasks, opened submenu.
  • Viewed as a user without edit permission, saw the menus greyed out.

Diff Detail

Repository
rP Phabricator
Branch
attach4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12844
Build 16367: Run Core Tests
Build 16366: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38967.Jun 30 2016, 5:24 PM
epriestley retitled this revision from to When all actions in a submenu are disabled, disable the submenu header.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11240: Expandable menus are not greyed out, even if all options are not useable.
epriestley added inline comments.Jun 30 2016, 5:31 PM
src/applications/search/controller/PhabricatorSearchBaseController.php
5–10

Not exactly related, but nothing uses these anymore.

chad accepted this revision.Jun 30 2016, 5:35 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2016, 5:35 PM
Closed by commit rP7574f8dcf51a: When all actions in a submenu are disabled, disable the submenu header (authored by epriestley, committed by epriestley). · Explain WhyJun 30 2016, 5:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
22 lines
maniphest/
controller/
30 lines
search/
controller/
7 lines
relationship/
37 lines
view/
layout/
4 lines

Diff 38967

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchBaseController.php

Loading...
View Options

src/applications/search/relationship/PhabricatorObjectRelationshipList.php

Loading...
View Options

src/view/layout/PhabricatorActionView.php

Loading...
Phabricator · Built by Phacility