HomePhabricator

Convert Maniphest merge operations to modern Relationship code

Authored by epriestley on Jun 29 2016, 6:09 PM.

Description

Convert Maniphest merge operations to modern Relationship code

Summary:
Ref T4788. Fixes T7820. This updates the "Merge Duplicates In" interaction, and adds a "Close as Duplicate" action.

These are the last interactions that were using the old code, so it removes that code.

Merges are now recorded as real edges, so we can show them in the UI later on (originally from T9390, etc).

Also provides more general support for relationships which need EDIT permission, not-undoable relationships like merges, preventing relating an object to itself, and relationship side effects like merges.

Finally, fixes a couple of behaviors around typing an exact object name (like T123) to find the related object.

Test Plan:

  • Merged tasks into the current task.
  • Closed the current task as a duplicate of another task.
  • Edited other relationships.
  • Searched for tasks, commits, etc., by object monogram.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4788, T7820

Differential Revision: https://secure.phabricator.com/D16196