Page MenuHomePhabricator
Differential D16201

When all actions in a submenu are disabled, disable the submenu header
ClosedPublic
Actions

Authored by epriestley on Jun 30 2016, 5:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 14, 4:36 AM
Unknown Object (File)
Dec 13 2024, 10:36 AM
Unknown Object (File)
Dec 11 2024, 8:48 AM
Unknown Object (File)
Dec 4 2024, 9:54 AM
Unknown Object (File)
Dec 4 2024, 5:47 AM
Unknown Object (File)
Nov 30 2024, 5:05 PM
Unknown Object (File)
Oct 23 2024, 4:44 PM
Unknown Object (File)
Oct 23 2024, 6:38 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11240: Expandable menus are not greyed out, even if all options are not useable
Commits
rP7574f8dcf51a: When all actions in a submenu are disabled, disable the submenu header
Summary

Fixes T11240. Also simplify things a little and share a bit more code.

Test Plan
  • Viewed revisions and tasks, opened submenu.
  • Viewed as a user without edit permission, saw the menus greyed out.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38967.Jun 30 2016, 5:24 PM
epriestley retitled this revision from to When all actions in a submenu are disabled, disable the submenu header.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11240: Expandable menus are not greyed out, even if all options are not useable.
epriestley added inline comments.Jun 30 2016, 5:31 PM
src/applications/search/controller/PhabricatorSearchBaseController.php
5–10

Not exactly related, but nothing uses these anymore.

chad accepted this revision.Jun 30 2016, 5:35 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2016, 5:35 PM
Closed by commit rP7574f8dcf51a: When all actions in a submenu are disabled, disable the submenu header (authored by epriestley, committed by epriestley). · Explain WhyJun 30 2016, 5:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
22 lines
maniphest/
controller/
30 lines
search/
controller/
7 lines
relationship/
37 lines
view/
layout/
4 lines

Diff 38969

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchBaseController.php

Loading...
View Options

src/applications/search/relationship/PhabricatorObjectRelationshipList.php

Loading...
View Options

src/view/layout/PhabricatorActionView.php

Loading...
Phabricator · Built by Phacility