Differential D16198

Wrap really long text properly in diffs
ClosedPublic
Actions

Authored by chad on Jun 30 2016, 3:28 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T11236: Regression: side-by-side diffs: very long lines overflow in diffusion

Commits

rP922822bd2dc3: Wrap really long text properly in diffs

Summary

Fixes T11236, breaks long words and inlines the spans.

Test Plan

Use a diff with super long text like SSH keys, set Font to 24/48 Impact

Diff Detail

Repository

rP Phabricator

Branch

break-all-words (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12838
Build 16358: Run Core Tests
Build 16357: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38961.Jun 30 2016, 3:28 AM

chad retitled this revision from to Wrap really long text properly in diffs.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T11236: Regression: side-by-side diffs: very long lines overflow in diffusion.

Herald added a subscriber: Korvin. · View Herald TranscriptJun 30 2016, 3:28 AM

chad edited the test plan for this revision. (Show Details)Jun 30 2016, 3:28 AM

epriestley accepted this revision.Jun 30 2016, 4:14 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 30 2016, 4:14 AM

Closed by commit rP922822bd2dc3: Wrap really long text properly in diffs (authored by chad, committed by chad). · Explain WhyJun 30 2016, 4:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

css/

core/

syntax.css

3 lines

Diff 38961

View Options

resources/celerity/map.php