Differential D16163

Drive modular task relationships through a new "relationships" controller
ClosedPublic
Actions

Authored by epriestley on Jun 22 2016, 3:15 PM.

Tags

None

Subscribers

None

Details

Reviewers

Maniphest Tasks

T11179: Figure out what to do with "Edit Blocking Tasks", "Edit Differential Revisions" and "Edit Pholio Mocks"

Commits

rPb5d90b4714b2: Drive modular task relationships through a new "relationships" controller

Summary

Ref T11179. This is basically a "pro" controller to replace the SearchAttach controller. It does basically the same stuff, just in a (mostly) more modern and modular way.

Test Plan

Added and removed mocks.
Added and removed revisions.
Everything worked just like it did before.

Diff Detail

Repository

Branch

relation2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/search/controller/PhabricatorSearchRelationshipController.php:53	XHP16	TODO Comment
Advice	src/applications/search/controller/PhabricatorSearchRelationshipController.php:123	XHP16	TODO Comment
Advice	src/applications/search/controller/PhabricatorSearchRelationshipController.php:136	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 12762
Build 16242: Run Core Tests
Build 16241: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38881.Jun 22 2016, 3:15 PM

epriestley retitled this revision from to Drive modular task relationships through a new "relationships" controller.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11179: Figure out what to do with "Edit Blocking Tasks", "Edit Differential Revisions" and "Edit Pholio Mocks".

chad accepted this revision.Jun 22 2016, 4:43 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 22 2016, 4:43 PM

Closed by commit rPb5d90b4714b2: Drive modular task relationships through a new "relationships" controller (authored by epriestley, committed by epriestley). · Explain WhyJun 22 2016, 6:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

maniphest/

relationship/

ManiphestTaskHasCommitRelationship.php

16 lines

ManiphestTaskHasMockRelationship.php

16 lines

ManiphestTaskHasRevisionRelationship.php

16 lines

search/

application/

PhabricatorSearchApplication.php

2 lines

controller/

PhabricatorSearchRelationshipController.php

198 lines

relationship/

PhabricatorObjectRelationship.php

30 lines

PhabricatorObjectRelationshipList.php

4 lines

Diff 38881

src/__phutil_library_map__.php

Loading...

src/applications/maniphest/relationship/ManiphestTaskHasCommitRelationship.php

Loading...

src/applications/maniphest/relationship/ManiphestTaskHasMockRelationship.php

Loading...

src/applications/maniphest/relationship/ManiphestTaskHasRevisionRelationship.php

Loading...

src/applications/search/application/PhabricatorSearchApplication.php

Loading...

src/applications/search/controller/PhabricatorSearchRelationshipController.php

Loading...

src/applications/search/relationship/PhabricatorObjectRelationship.php

Loading...

src/applications/search/relationship/PhabricatorObjectRelationshipList.php

Loading...