Page MenuHomePhabricator

Render dropdown metadata earlier
ClosedPublic

Authored by epriestley on Jun 20 2016, 6:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2024, 12:04 PM
Unknown Object (File)
Feb 14 2024, 1:49 PM
Unknown Object (File)
Feb 14 2024, 1:45 PM
Unknown Object (File)
Feb 14 2024, 1:23 PM
Unknown Object (File)
Jan 26 2024, 10:25 PM
Unknown Object (File)
Dec 27 2023, 7:35 AM
Unknown Object (File)
Dec 21 2023, 2:06 PM
Unknown Object (File)
Dec 13 2023, 8:58 PM
Subscribers
None

Details

Summary

Ref T11179. One issue I'm getting with trying to turn actions into dropdowns is that we currently render this menu very late, which can cause us to try to add more metadata after we start resolving metadata. This won't work right now (and making it work seems unreasonably complicated), so stop doing it and fatal if something tries.

(This might make some things fatal but should be safe -- anything that fatals should have been broken already.)

Test Plan

Browsed around looking for fatals, didn't see any.

(This primarily avoids a broken state / fatal in a future diff.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Render dropdown metadata earlier.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2016, 6:58 PM
This revision was automatically updated to reflect the committed changes.