Page MenuHomePhabricator

Render prose diffs in email as summaries
ClosedPublic

Authored by epriestley on Jun 10 2016, 3:30 PM.
Tags
None
Referenced Files
F13152606: D16098.diff
Sat, May 4, 8:31 PM
Unknown Object (File)
Sun, Apr 28, 2:05 PM
Unknown Object (File)
Sat, Apr 27, 3:58 PM
Unknown Object (File)
Sun, Apr 21, 8:53 PM
Unknown Object (File)
Fri, Apr 19, 4:53 PM
Unknown Object (File)
Fri, Apr 12, 1:49 AM
Unknown Object (File)
Fri, Apr 5, 11:56 AM
Unknown Object (File)
Apr 5 2024, 2:18 AM
Subscribers
None

Details

Summary

Ref T7643. When a large block of prose text is edited (like a wiki page), summarize the diff when sending mail.

For now, I'm still showing the whole thing in the web UI, since it's a bit more manageable there.

Also try to fix newlines in Airmail.

Test Plan

This web diff:

Screen Shot 2016-06-10 at 8.20.08 AM.png (546×621 px, 99 KB)

..became this mail diff:

Screen Shot 2016-06-10 at 8.18.29 AM.png (717×914 px, 116 KB)

Diff Detail

Repository
rP Phabricator
Branch
prose8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12598
Build 15993: Run Core Tests
Build 15992: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Render prose diffs in email as summaries.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 10 2016, 4:28 PM
This revision was automatically updated to reflect the committed changes.