Page MenuHomePhabricator

Use HTTPEngineExtension proxy for `git` HTTP operations
ClosedPublic

Authored by epriestley on Jun 9 2016, 6:50 PM.
Tags
None
Referenced Files
F13987385: D16092.id.diff
Mon, Oct 21, 9:06 AM
Unknown Object (File)
Sep 15 2024, 10:35 AM
Unknown Object (File)
Sep 5 2024, 8:41 PM
Unknown Object (File)
Sep 5 2024, 8:41 PM
Unknown Object (File)
Sep 5 2024, 8:40 PM
Unknown Object (File)
Sep 3 2024, 10:36 AM
Unknown Object (File)
Sep 2 2024, 4:11 AM
Unknown Object (File)
Sep 2 2024, 4:04 AM
Subscribers
None

Details

Summary

Ref T10227. When we perform git http operations (fetch, mirror) check if we should use a proxy; if we should, set http_proxy or https_proxy in the environment to make git have curl use it.

Test Plan
  • Configured a proxy extension to run stuff through a local instance of Charles.
  • Ran repository pull and repository mirror.
  • Saw git HTTP requests route through the proxy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable