Page MenuHomePhabricator
Differential D16088

Allow Pholio mocks to be created and edited without drag-and-drop
ClosedPublic
Actions

Authored by epriestley on Jun 9 2016, 3:40 PM.
Tags
None
Referenced Files
F14035745: D16088.id38709.diff
Sun, Nov 10, 7:20 AM
F14035635: D16088.id.diff
Sun, Nov 10, 6:55 AM
F14035496: D16088.id.diff
Sun, Nov 10, 6:13 AM
F14035319: D16088.id38707.diff
Sun, Nov 10, 5:28 AM
F14034708: D16088.id38709.diff
Sun, Nov 10, 1:50 AM
F14034492: D16088.diff
Sun, Nov 10, 12:36 AM
F14030310: D16088.diff
Sat, Nov 9, 2:13 AM
F14018172: D16088.diff
Tue, Nov 5, 5:41 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T6523: Allow creating/adding images to mocks with a vanilla upload control
Commits
rP4d12c58dcf86: Allow Pholio mocks to be created and edited without drag-and-drop
Summary

Ref T6523. Allows you to click stuff instead of using drag-and-drop.

Test Plan

On iOS simulator, created and updated a mock.

Diff Detail

Repository
rP Phabricator
Branch
pholio2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12578
Build 15962: Run Core Tests
Build 15961: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38707.Jun 9 2016, 3:40 PM
epriestley retitled this revision from to Allow Pholio mocks to be created and edited without drag-and-drop.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T6523: Allow creating/adding images to mocks with a vanilla upload control.
Herald edited edge metadata. · View Herald TranscriptJun 9 2016, 3:40 PM
epriestley mentioned this in T6523: Allow creating/adding images to mocks with a vanilla upload control.Jun 9 2016, 3:42 PM
chad accepted this revision.Jun 9 2016, 3:42 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 9 2016, 3:42 PM
Closed by commit rP4d12c58dcf86: Allow Pholio mocks to be created and edited without drag-and-drop (authored by epriestley, committed by epriestley). · Explain WhyJun 9 2016, 3:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
28 lines
src/
applications/
files/
application/
3 lines
controller/
8 lines
pholio/
controller/
4 lines
view/
3 lines
webroot/
rsrc/
css/
application/
pholio/
10 lines
js/
application/
pholio/
79 lines

Diff 38707

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/files/application/PhabricatorFilesApplication.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileUploadDialogController.php

Loading...
View Options

src/applications/pholio/controller/PholioMockEditController.php

Loading...
View Options

src/applications/pholio/view/PholioUploadedImageView.php

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio-edit.css

Loading...
View Options

webroot/rsrc/js/application/pholio/behavior-pholio-mock-edit.js

Loading...
Phabricator · Built by Phacility