Differential D16069

Use EditDistanceMatrix diff smoothing in Arcanist
ClosedPublic
Actions

Authored by epriestley on Jun 7 2016, 3:27 PM.

Details

Reviewers

chad

Maniphest Tasks

T7643: Improve prose diffs (was: description changes don't generate usable diffs)

Commits

rARC41e8e30e8c13: Use EditDistanceMatrix diff smoothing in Arcanist

Summary

Ref T7643. We've done the smoothing from D16068 for a long time, it just wasn't part of EditDistanceMatrix.

Since it now is, call it instead of keeping a copy of the logic around.

Previously, the unit tests were testing un-smoothed diffs. Just have them test smoothed diffs instead, since nothing actually uses unsmoothed diffs.

Test Plan

Pasted a raw diff into the web UI, got a sensible inline diff for it.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38661.Jun 7 2016, 3:27 PM

epriestley retitled this revision from to Use EditDistanceMatrix diff smoothing in Arcanist.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T7643: Improve prose diffs (was: description changes don't generate usable diffs).

chad accepted this revision.Jun 7 2016, 4:09 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 7 2016, 4:09 PM

Closed by commit rARC41e8e30e8c13: Use EditDistanceMatrix diff smoothing in Arcanist (authored by epriestley, committed by epriestley). · Explain WhyJun 7 2016, 4:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

difference/

ArcanistDiffUtils.php

20 lines

__tests__/

ArcanistDiffUtilsTestCase.php

4 lines

Diff 38665

View Options

src/difference/ArcanistDiffUtils.php

View Options

src/difference/tests/ArcanistDiffUtilsTestCase.php

Use EditDistanceMatrix diff smoothing in ArcanistClosedPublicActions