Page MenuHomePhabricator

Centralize "this is the current user for the request" code
ClosedPublic

Authored by epriestley on Jun 7 2016, 2:00 PM.
Tags
None
Referenced Files
F13176454: D16066.diff
Wed, May 8, 2:09 PM
Unknown Object (File)
Sat, May 4, 6:43 PM
Unknown Object (File)
Thu, May 2, 4:21 AM
Unknown Object (File)
Wed, May 1, 12:03 AM
Unknown Object (File)
Fri, Apr 26, 1:17 AM
Unknown Object (File)
Fri, Apr 19, 4:51 PM
Unknown Object (File)
Thu, Apr 11, 8:52 AM
Unknown Object (File)
Apr 7 2024, 5:47 AM
Subscribers
None

Details

Summary

Ref T11098. This primarily fixes Conduit calls to *.edit methods failing when trying to access user preferences.

(The actual access is a little weird, since it seems like we're building some UI stuff inside a policy query, but that's an issue for another time.)

To fix this, consolidate the "we're about to run some kind of request with this user" code and run it consistently for web, conduit, and SSH sessions.

Additionally, make sure we swap things to the user's translation.

Test Plan
  • Ran maniphest.edit via arc call-conduit, no more settings exception.
  • Set translation to ALL CAPS, got all caps output from ssh and Conduit.

Diff Detail

Repository
rP Phabricator
Branch
conduit2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12528
Build 15889: Run Core Tests
Build 15888: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Centralize "this is the current user for the request" code.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, avivey.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 2:09 PM
This revision was automatically updated to reflect the committed changes.