Page MenuHomePhabricator

Centralize "this is the current user for the request" code
ClosedPublic

Authored by epriestley on Jun 7 2016, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 1:17 AM
Unknown Object (File)
Fri, Apr 19, 4:51 PM
Unknown Object (File)
Thu, Apr 11, 8:52 AM
Unknown Object (File)
Sun, Apr 7, 5:47 AM
Unknown Object (File)
Sun, Mar 31, 10:32 PM
Unknown Object (File)
Feb 10 2024, 4:03 PM
Unknown Object (File)
Feb 3 2024, 10:38 AM
Unknown Object (File)
Jan 23 2024, 9:53 AM
Subscribers
None

Details

Summary

Ref T11098. This primarily fixes Conduit calls to *.edit methods failing when trying to access user preferences.

(The actual access is a little weird, since it seems like we're building some UI stuff inside a policy query, but that's an issue for another time.)

To fix this, consolidate the "we're about to run some kind of request with this user" code and run it consistently for web, conduit, and SSH sessions.

Additionally, make sure we swap things to the user's translation.

Test Plan
  • Ran maniphest.edit via arc call-conduit, no more settings exception.
  • Set translation to ALL CAPS, got all caps output from ssh and Conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Centralize "this is the current user for the request" code.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, avivey.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 2:09 PM
This revision was automatically updated to reflect the committed changes.