Page MenuHomePhabricator

Use prose diffs in Phriction
ClosedPublic

Authored by epriestley on Jun 6 2016, 9:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 28, 4:11 PM
Unknown Object (File)
Sun, Nov 20, 11:13 AM
Unknown Object (File)
Thu, Nov 10, 1:51 PM
Unknown Object (File)
Wed, Nov 9, 8:31 PM
Unknown Object (File)
Wed, Nov 9, 10:46 AM
Unknown Object (File)
Tue, Nov 8, 9:50 PM
Unknown Object (File)
Oct 12 2022, 9:39 PM
Unknown Object (File)
Oct 5 2022, 7:25 PM
Subscribers
Tokens
"Love" token, awarded by avivey.

Details

Summary

Ref T3353. This improves whitespace display of prose diffs and uses them in Phriction.

Test Plan

Screen Shot 2016-06-06 at 1.58.36 PM.png (1×1 px, 251 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use prose diffs in Phriction.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

This is awesome, but is it really on the way to T3353? Wouldn't we need to replace it with a view that supports inline-comments?

This revision is now accepted and ready to land.Jun 6 2016, 9:14 PM

I'll clarify T3353 shortly -- I'm not planning to, e.g., implement Google Docs.

This revision was automatically updated to reflect the committed changes.