Page MenuHomePhabricator

Use prose diffs in Phriction
ClosedPublic

Authored by epriestley on Jun 6 2016, 9:01 PM.

Details

Summary

Ref T3353. This improves whitespace display of prose diffs and uses them in Phriction.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Use prose diffs in Phriction.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

This is awesome, but is it really on the way to T3353? Wouldn't we need to replace it with a view that supports inline-comments?

This revision is now accepted and ready to land.Jun 6 2016, 9:14 PM

I'll clarify T3353 shortly -- I'm not planning to, e.g., implement Google Docs.

This revision was automatically updated to reflect the committed changes.