Use prose diffs in Phriction
ClosedPublic
Actions

Authored by epriestley on Jun 6 2016, 9:01 PM.

Tags

None

Referenced Files

	F14054456: D16062.diff
	Sat, Nov 16, 1:53 AM

	F14042311: D16062.diff
	Tue, Nov 12, 2:26 AM

	F14027005: D16062.diff
	Fri, Nov 8, 4:10 AM

	F14021316: D16062.diff
	Wed, Nov 6, 7:12 AM

	F14005978: D16062.id38648.diff
	Sun, Oct 27, 10:58 PM

	F13987666: D16062.id38648.diff
	Mon, Oct 21, 10:37 AM

	F13977957: D16062.id.diff
	Oct 18 2024, 8:49 PM

	F13958502: D16062.id38650.diff
	Oct 14 2024, 3:08 PM

View All Files

Subscribers

avivey

Tokens

"Love" token, awarded by avivey.

Details

Reviewers

avivey
chad

Maniphest Tasks

T3353: Make Phriction Document changes reviewable

Commits

rP02877c600a75: Use prose diffs in Phriction

Summary

Ref T3353. This improves whitespace display of prose diffs and uses them in Phriction.

Test Plan

Screen Shot 2016-06-06 at 1.58.36 PM.png (1×1 px, 251 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38648.Jun 6 2016, 9:01 PM

epriestley retitled this revision from to Use prose diffs in Phriction.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T3353: Make Phriction Document changes reviewable.

Herald edited edge metadata. · View Herald TranscriptJun 6 2016, 9:01 PM

avivey awarded a token.Jun 6 2016, 9:11 PM

This is awesome, but is it really on the way to T3353? Wouldn't we need to replace it with a view that supports inline-comments?

This revision is now accepted and ready to land.Jun 6 2016, 9:14 PM

I'll clarify T3353 shortly -- I'm not planning to, e.g., implement Google Docs.

Closed by commit rP02877c600a75: Use prose diffs in Phriction (authored by epriestley, committed by epriestley). · Explain WhyJun 6 2016, 9:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

controller/

PhrictionDiffController.php

65 lines

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

8 lines

Diff 38650

View Options

src/applications/phriction/controller/PhrictionDiffController.php