Page MenuHomePhabricator

Allow users to unset "Editor", tailor short error messages properly on settings forms
ClosedPublic

Authored by epriestley on Jun 5 2016, 8:54 PM.
Tags
None
Referenced Files
F15455747: D16051.diff
Sun, Mar 30, 4:35 AM
F15442106: D16051.id38622.diff
Wed, Mar 26, 9:32 PM
F15442105: D16051.id.diff
Wed, Mar 26, 9:32 PM
F15442026: D16051.diff
Wed, Mar 26, 9:02 PM
F15423673: D16051.id38620.diff
Sat, Mar 22, 4:37 PM
F15414263: D16051.id38622.diff
Wed, Mar 19, 11:47 PM
F15413931: D16051.id38622.diff
Wed, Mar 19, 10:04 PM
F15334337: D16051.id38622.diff
Sat, Mar 8, 8:19 AM
Subscribers
None

Details

Summary

Ref T11098.

  • Allow "Editor" to be set to the empty string.
  • Don't match a validation error to a field unless the actual settings for the field and error match.
Test Plan
  • Tried to set "Editor" to "", success.
  • Tried to set "Editor" to "javascript://", only that field got marked "Invalid".

Diff Detail

Repository
rP Phabricator
Branch
setting40
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12491
Build 15833: Run Core Tests
Build 15832: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow users to unset "Editor", tailor short error messages properly on settings forms.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, avivey.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2016, 9:02 PM
This revision was automatically updated to reflect the committed changes.