Page MenuHomePhabricator

Allow users to unset "Editor", tailor short error messages properly on settings forms
ClosedPublic

Authored by epriestley on Jun 5 2016, 8:54 PM.
Tags
None
Referenced Files
F18798863: D16051.diff
Fri, Oct 17, 9:29 AM
F18749126: D16051.id38620.diff
Sat, Oct 4, 2:27 AM
F18710838: D16051.id38622.diff
Mon, Sep 29, 2:57 AM
F18703090: D16051.id.diff
Sun, Sep 28, 2:57 AM
F18694737: D16051.id38620.diff
Sat, Sep 27, 3:59 AM
F18585711: D16051.id38620.diff
Sep 11 2025, 4:09 PM
F18584745: D16051.id38622.diff
Sep 11 2025, 1:31 PM
F18583066: D16051.id38622.diff
Sep 11 2025, 9:23 AM
Subscribers
None

Details

Summary

Ref T11098.

  • Allow "Editor" to be set to the empty string.
  • Don't match a validation error to a field unless the actual settings for the field and error match.
Test Plan
  • Tried to set "Editor" to "", success.
  • Tried to set "Editor" to "javascript://", only that field got marked "Invalid".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow users to unset "Editor", tailor short error messages properly on settings forms.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, avivey.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2016, 9:02 PM
This revision was automatically updated to reflect the committed changes.