Fix exception when trying to save global setting mail tags
ClosedPublic
Actions

Authored by epriestley on Jun 5 2016, 8:41 PM.

Details

Reviewers

avivey
chad

Maniphest Tasks

T11098: Feedback and Errata for Global Settings

Commits

rP4936be0868bd: Fix exception when trying to save global setting mail tags

Summary

Ref T11098. Template preferences don't have a user, but this codepath didn't get fully updated to account for that.

Test Plan

Saved mail tags in global prefernces.

Diff Detail

Repository

rP Phabricator

Branch

setting39

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12489
Build 15830: Run Core Tests
Build 15829: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38618.Jun 5 2016, 8:41 PM

epriestley retitled this revision from to Fix exception when trying to save global setting mail tags.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, avivey.

epriestley added a task: T11098: Feedback and Errata for Global Settings.

chad accepted this revision.Jun 5 2016, 8:45 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 5 2016, 8:45 PM

Closed by commit rP4936be0868bd: Fix exception when trying to save global setting mail tags (authored by epriestley, committed by epriestley). · Explain WhyJun 5 2016, 8:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

panel/

PhabricatorEmailPreferencesSettingsPanel.php

2 lines

Diff 38618

View Options

src/applications/settings/panel/PhabricatorEmailPreferencesSettingsPanel.php

Fix exception when trying to save global setting mail tagsClosedPublicActions