Differential D16045

Fully modularize the "Quick Actions" menu
ClosedPublic
Actions

Authored by epriestley on Jun 5 2016, 2:34 PM.

Details

Reviewers

chad

Maniphest Tasks

T10077: Reduce the cost of building the "Quick Create" menu

Commits

rP7969f66dfe07: Fully modularize the "Quick Actions" menu

Summary

Ref T10077. Currently, we issue 6+ queries on every page to build this menu, since the menu is built application-by-application.

Build the menu with dedicated modules instead so a single "EditEngine" module can provide all of them with one query.

I'd like to reduce this to 0 queries but I'm not totally sure what we want to do with this menu.

This change removes these items, because EditEngine can not currently provide them:

Calendar: Eventually via EditEngine eventually.
Conpherence: Probably via EditEngine, doesn't seem too important.
People: Maybe via EditEngine, doesn't seem too important? "Welcome" is likely better?
Pholio: Eventually via EditEngine.

It adds a bunch of other items as a side effect:

Screen Shot 2016-06-05 at 7.26.04 AM.png (417×220 px, 30 KB)

This reduces the queries issued on every page by ~5.

This also makes quick create actions visible while logged out (see T7073).

Test Plan

Viewed menu while logged in.
Viewed menu while logged out.
Viewed standalone version of menu.

Diff Detail

Repository

rP Phabricator

Branch

setting34

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12470
Build 15806: Run Core Tests
Build 15805: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38599.Jun 5 2016, 2:34 PM

epriestley retitled this revision from to Fully modularize the "Quick Actions" menu.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10077: Reduce the cost of building the "Quick Create" menu.

I'm not sure what the long-term version of this menu looks like. This moves slightly toward maybe putting some things like flags into it.

(Personally, I never use this menu.)

The shortest-effort, reasonable-ish path is probably to add an option to let applications opt out of the menu, and then hide badges, blogs/posts, EditEngine forms, and packages (leaving tasks, pastes and projects -- do we even need projects?).

I can force other stuff (people, pholio, etc) back into the menu for now if you don't want to remove them.