Page MenuHomePhabricator
Differential D16043

Simplify user cache management of data forms
ClosedPublic
Actions

Authored by epriestley on Jun 5 2016, 1:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 7:08 AM
Unknown Object (File)
Wed, Dec 11, 9:44 AM
Unknown Object (File)
Wed, Dec 11, 9:44 AM
Unknown Object (File)
Wed, Dec 11, 9:44 AM
Unknown Object (File)
Wed, Dec 11, 8:54 AM
Unknown Object (File)
Thu, Dec 5, 10:44 AM
Unknown Object (File)
Tue, Dec 3, 1:46 PM
Unknown Object (File)
Nov 12 2024, 10:22 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4103: Implement "Role Profiles" to provide search, homepage and application defaults
T10078: Implement global readthrough cache pools
Commits
rP5ba7938d5429: Simplify user cache management of data forms
Summary

Ref T4103. Ref T10078. We currently have separate "usable" and "raw" values, but can simplify this by making newValueForUsers() return the raw value.

Test Plan

Ran unit tests; browsed around; dropped caches and browsed around.

Diff Detail

Repository
rP Phabricator
Branch
setting32
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12468
Build 15802: Run Core Tests
Build 15801: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38597.Jun 5 2016, 1:53 PM
epriestley retitled this revision from to Simplify user cache management of data forms.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10078: Implement global readthrough cache pools, T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
chad accepted this revision.Jun 5 2016, 3:08 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2016, 3:08 PM
Closed by commit rP5ba7938d5429: Simplify user cache management of data forms (authored by epriestley, committed by epriestley). · Explain WhyJun 5 2016, 3:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38597

View Options

src/applications/people/cache/PhabricatorUserCacheType.php

Loading...
View Options

src/applications/people/cache/PhabricatorUserMessageCountCacheType.php

Loading...
View Options

src/applications/people/cache/PhabricatorUserNotificationCountCacheType.php

Loading...
View Options

src/applications/people/cache/PhabricatorUserPreferencesCacheType.php

Loading...
View Options

src/applications/people/cache/PhabricatorUserProfileImageCacheType.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
Phabricator · Built by Phacility