Page MenuHomePhabricator

Modernize Conpherence access to user preferences
ClosedPublic

Authored by epriestley on Jun 3 2016, 2:41 PM.
Tags
None
Referenced Files
F16391836: D16025.diff
Mon, Jun 16, 12:43 AM
Unknown Object (File)
Mon, Jun 2, 5:23 AM
Unknown Object (File)
Mon, Jun 2, 1:28 AM
Unknown Object (File)
Sun, Jun 1, 4:39 PM
Unknown Object (File)
Sun, Jun 1, 4:39 PM
Unknown Object (File)
Sun, Jun 1, 4:39 PM
Unknown Object (File)
Tue, May 27, 4:06 PM
Unknown Object (File)
Tue, May 27, 11:12 AM
Subscribers
None

Details

Summary

Ref T4103. Conpherence is doing some weird stuff and has its own redudnant settings object.

  • Get rid of ConpherenceSettings.
  • Use getUserSetting() instead of loadPreferences().
  • When applying transactions, add a new mechanism to efficiently prefill caches (this will still work anyway, but it's slower if we don't bulk-fetch).
Test Plan
  • Changed global Conpherence setting.
  • Created a new Conpherence, saw setting set to global default.
  • Changed local room setting.
  • Submitted messages.
  • Saw cache prefill for all particpiants in database.

Diff Detail

Repository
rP Phabricator
Branch
setting15
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12425
Build 15737: Run Core Tests
Build 15736: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modernize Conpherence access to user preferences.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 6:56 PM
This revision was automatically updated to reflect the committed changes.