Page MenuHomePhabricator

Modernize Conpherence access to user preferences
ClosedPublic

Authored by epriestley on Jun 3 2016, 2:41 PM.
Tags
None
Referenced Files
F15453754: D16025.id38577.diff
Sat, Mar 29, 2:08 PM
F15452039: D16025.id38556.diff
Sat, Mar 29, 1:20 AM
F15446078: D16025.id.diff
Thu, Mar 27, 5:03 PM
F15441407: D16025.diff
Wed, Mar 26, 6:03 PM
F15387787: D16025.id.diff
Sat, Mar 15, 2:55 AM
F15383200: D16025.id38577.diff
Fri, Mar 14, 3:48 PM
F15382337: D16025.diff
Fri, Mar 14, 11:55 AM
F15381533: D16025.id.diff
Fri, Mar 14, 8:09 AM
Subscribers
None

Details

Summary

Ref T4103. Conpherence is doing some weird stuff and has its own redudnant settings object.

  • Get rid of ConpherenceSettings.
  • Use getUserSetting() instead of loadPreferences().
  • When applying transactions, add a new mechanism to efficiently prefill caches (this will still work anyway, but it's slower if we don't bulk-fetch).
Test Plan
  • Changed global Conpherence setting.
  • Created a new Conpherence, saw setting set to global default.
  • Changed local room setting.
  • Submitted messages.
  • Saw cache prefill for all particpiants in database.

Diff Detail

Repository
rP Phabricator
Branch
setting15
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12425
Build 15737: Run Core Tests
Build 15736: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modernize Conpherence access to user preferences.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 6:56 PM
This revision was automatically updated to reflect the committed changes.