Page MenuHomePhabricator

Modernize Conpherence access to user preferences
ClosedPublic

Authored by epriestley on Jun 3 2016, 2:41 PM.
Tags
None
Referenced Files
F13269937: D16025.diff
Wed, May 29, 8:15 AM
F13226922: D16025.diff
Mon, May 20, 12:12 AM
F13215322: D16025.id.diff
Fri, May 17, 4:35 PM
F13198961: D16025.diff
Mon, May 13, 10:39 AM
F13178199: D16025.diff
Wed, May 8, 8:15 PM
Unknown Object (File)
Apr 30 2024, 9:24 AM
Unknown Object (File)
Apr 25 2024, 2:32 AM
Unknown Object (File)
Apr 19 2024, 4:47 PM
Subscribers
None

Details

Summary

Ref T4103. Conpherence is doing some weird stuff and has its own redudnant settings object.

  • Get rid of ConpherenceSettings.
  • Use getUserSetting() instead of loadPreferences().
  • When applying transactions, add a new mechanism to efficiently prefill caches (this will still work anyway, but it's slower if we don't bulk-fetch).
Test Plan
  • Changed global Conpherence setting.
  • Created a new Conpherence, saw setting set to global default.
  • Changed local room setting.
  • Submitted messages.
  • Saw cache prefill for all particpiants in database.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modernize Conpherence access to user preferences.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 6:56 PM
This revision was automatically updated to reflect the committed changes.