Page MenuHomePhabricator

Modernize Conpherence access to user preferences
ClosedPublic

Authored by epriestley on Jun 3 2016, 2:41 PM.
Tags
None
Referenced Files
F18824561: D16025.id.diff
Thu, Oct 23, 4:23 PM
F18821980: D16025.diff
Thu, Oct 23, 3:18 AM
F18821789: D16025.id38556.diff
Thu, Oct 23, 1:49 AM
F18821729: D16025.diff
Thu, Oct 23, 1:29 AM
F18811714: D16025.id38556.diff
Mon, Oct 20, 4:30 AM
F18749383: D16025.diff
Sat, Oct 4, 3:38 AM
F18745577: D16025.id38577.diff
Fri, Oct 3, 8:07 AM
F18744958: D16025.id.diff
Fri, Oct 3, 4:48 AM
Subscribers
None

Details

Summary

Ref T4103. Conpherence is doing some weird stuff and has its own redudnant settings object.

  • Get rid of ConpherenceSettings.
  • Use getUserSetting() instead of loadPreferences().
  • When applying transactions, add a new mechanism to efficiently prefill caches (this will still work anyway, but it's slower if we don't bulk-fetch).
Test Plan
  • Changed global Conpherence setting.
  • Created a new Conpherence, saw setting set to global default.
  • Changed local room setting.
  • Submitted messages.
  • Saw cache prefill for all particpiants in database.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modernize Conpherence access to user preferences.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 6:56 PM
This revision was automatically updated to reflect the committed changes.