Page MenuHomePhabricator

Convert "Account" and "Date and Time" settings to EditEngine
ClosedPublic

Authored by epriestley on Jun 3 2016, 12:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 24, 4:06 AM
Unknown Object (File)
Sun, Dec 22, 8:00 AM
Unknown Object (File)
Fri, Dec 20, 4:08 PM
Unknown Object (File)
Sat, Dec 7, 9:07 PM
Unknown Object (File)
Sat, Nov 30, 10:13 AM
Unknown Object (File)
Nov 17 2024, 12:18 AM
Unknown Object (File)
Nov 12 2024, 4:10 AM
Unknown Object (File)
Nov 11 2024, 12:16 PM
Subscribers
None

Details

Summary

Ref T4103. This pretty much replaces these panels in-place with similar looking ones that go through EditEngine.

This has a few rough edges but they're pretty minor and/or hard to hit (for example, when editing another user's settings, the crumbs have a redundant link in them).

Test Plan
  • Edited my own settings.
  • Edited a bot user's settings.
  • Tried to edit another user's settings (failed).

Screen Shot 2016-06-03 at 5.05.38 AM.png (1×1 px, 164 KB)

Diff Detail

Repository
rP Phabricator
Branch
setting8
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/settings/setting/PhabricatorPronounSetting.php:29XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 12416
Build 15721: Run Core Tests
Build 15720: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Convert "Account" and "Date and Time" settings to EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 2:48 PM
This revision was automatically updated to reflect the committed changes.