Page MenuHomePhabricator

Convert "Account" and "Date and Time" settings to EditEngine
ClosedPublic

Authored by epriestley on Jun 3 2016, 12:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 6:22 PM
Unknown Object (File)
Mon, Mar 18, 7:44 PM
Unknown Object (File)
Mon, Mar 18, 6:49 PM
Unknown Object (File)
Mon, Mar 18, 5:30 PM
Unknown Object (File)
Sun, Mar 10, 2:05 AM
Unknown Object (File)
Fri, Mar 1, 12:32 AM
Unknown Object (File)
Fri, Mar 1, 12:32 AM
Unknown Object (File)
Fri, Mar 1, 12:31 AM
Subscribers
None

Details

Summary

Ref T4103. This pretty much replaces these panels in-place with similar looking ones that go through EditEngine.

This has a few rough edges but they're pretty minor and/or hard to hit (for example, when editing another user's settings, the crumbs have a redundant link in them).

Test Plan
  • Edited my own settings.
  • Edited a bot user's settings.
  • Tried to edit another user's settings (failed).

Screen Shot 2016-06-03 at 5.05.38 AM.png (1×1 px, 164 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Convert "Account" and "Date and Time" settings to EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 2:48 PM
This revision was automatically updated to reflect the committed changes.