Page MenuHomePhabricator

Convert "Account" and "Date and Time" settings to EditEngine
ClosedPublic

Authored by epriestley on Jun 3 2016, 12:13 PM.

Details

Summary

Ref T4103. This pretty much replaces these panels in-place with similar looking ones that go through EditEngine.

This has a few rough edges but they're pretty minor and/or hard to hit (for example, when editing another user's settings, the crumbs have a redundant link in them).

Test Plan
  • Edited my own settings.
  • Edited a bot user's settings.
  • Tried to edit another user's settings (failed).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 38547.Jun 3 2016, 12:13 PM
epriestley retitled this revision from to Convert "Account" and "Date and Time" settings to EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Jun 3 2016, 2:48 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 2:48 PM
This revision was automatically updated to reflect the committed changes.