Page MenuHomePhabricator
Differential D16008

Consider identifier types when sorting clone URIs
ClosedPublic
Actions

Authored by epriestley on Jun 2 2016, 1:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 12:17 AM
Unknown Object (File)
Fri, Dec 13, 12:57 AM
Unknown Object (File)
Thu, Dec 12, 10:50 PM
Unknown Object (File)
Thu, Dec 5, 2:25 AM
Unknown Object (File)
Sun, Dec 1, 11:29 PM
Unknown Object (File)
Fri, Nov 22, 10:57 PM
Unknown Object (File)
Fri, Nov 22, 10:35 AM
Unknown Object (File)
Nov 19 2024, 1:48 PM
View All Files
Subscribers
nikolay.metchev

Details

Reviewers
chad
Maniphest Tasks
T11082: Ordering of clone URIs incorrectly sorts less-preferred ID-based URIs above more-preferred callsign-based URIs
Commits
rP24acac117b9b: Consider identifier types when sorting clone URIs
Summary

Fixes T11082. Currently, the /123/ and /CALLSIGN/ versions of the URI get the same score.

Also the scores are backwards.

Test Plan
  • Added getPublicCloneURI() output to repository listing.
  • Before patch, saw a repository with a callsign list a less-preferred ID-based URI.
  • After patch, saw the repository list the more-preferred callsign-based URI.

Diff Detail

Repository
rP Phabricator
Branch
uriscore
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12404
Build 15704: Run Core Tests
Build 15703: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38528.Jun 2 2016, 1:44 PM
epriestley retitled this revision from to Consider identifier types when sorting clone URIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11082: Ordering of clone URIs incorrectly sorts less-preferred ID-based URIs above more-preferred callsign-based URIs.
nikolay.metchev added a subscriber: nikolay.metchev.Jun 2 2016, 1:46 PM
chad accepted this revision.Jun 2 2016, 1:56 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 2 2016, 1:56 PM
Closed by commit rP24acac117b9b: Consider identifier types when sorting clone URIs (authored by epriestley, committed by epriestley). · Explain WhyJun 2 2016, 1:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
storage/
5 lines
17 lines

Diff 38528

View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryURI.php

Loading...
Phabricator · Built by Phacility