Paths

Table of Contentst

Differential D16008

Consider identifier types when sorting clone URIs
ClosedPublic
Actions

Authored by epriestley on Jun 2 2016, 1:44 PM.

Details

Reviewers

chad

Maniphest Tasks

T11082: Ordering of clone URIs incorrectly sorts less-preferred ID-based URIs above more-preferred callsign-based URIs

Commits

rP24acac117b9b: Consider identifier types when sorting clone URIs

Summary

Fixes T11082. Currently, the /123/ and /CALLSIGN/ versions of the URI get the same score.

Also the scores are backwards.

Test Plan

Added getPublicCloneURI() output to repository listing.
Before patch, saw a repository with a callsign list a less-preferred ID-based URI.
After patch, saw the repository list the more-preferred callsign-based URI.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38528.Jun 2 2016, 1:44 PM

epriestley retitled this revision from to Consider identifier types when sorting clone URIs.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11082: Ordering of clone URIs incorrectly sorts less-preferred ID-based URIs above more-preferred callsign-based URIs.

nikolay.metchev added a subscriber: nikolay.metchev.Jun 2 2016, 1:46 PM

chad accepted this revision.Jun 2 2016, 1:56 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 2 2016, 1:56 PM

Closed by commit rP24acac117b9b: Consider identifier types when sorting clone URIs (authored by epriestley, committed by epriestley). · Explain WhyJun 2 2016, 1:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepository.php

5 lines

PhabricatorRepositoryURI.php

17 lines

Diff 38531

View Options

src/applications/repository/storage/PhabricatorRepository.php