Differential D15988

Stop two special cache writes in read-only mode
ClosedPublic
Actions

Authored by epriestley on May 30 2016, 3:46 PM.

Details

Reviewers

chad

Maniphest Tasks

T10769: Read-Only Mode Errata

Commits

rP92ea4fb098cb: Stop two special cache writes in read-only mode

Summary

Ref T10769. The user availability cache write shouldn't happen in read-only mode, nor should the Differential parse cache write.

(We might want to turn off the availbility feature completely since it's potentially expensive if we can't cache it, but I think we're OK for now.)

Test Plan

In read-only mode:

Browsed as a user with an out-of-date availability cache.
Loaded an older revision without cached parse data.

Diff Detail

Repository

rP Phabricator

Branch

xplain1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12361
Build 15640: Run Core Tests
Build 15639: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38484.May 30 2016, 3:46 PM

epriestley retitled this revision from to Stop two special cache writes in read-only mode.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10769: Read-Only Mode Errata.

chad accepted this revision.May 30 2016, 5:09 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 30 2016, 5:09 PM

Closed by commit rP92ea4fb098cb: Stop two special cache writes in read-only mode (authored by epriestley, committed by epriestley). · Explain WhyMay 30 2016, 5:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

4 lines

people/

storage/

PhabricatorUser.php

4 lines

Diff 38484

View Options

src/applications/differential/parser/DifferentialChangesetParser.php