Page MenuHomePhabricator
Differential D15987

Don't stop on read-only mode for read-only storage workflows
ClosedPublic
Actions

Authored by epriestley on May 30 2016, 3:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 9:41 PM
Unknown Object (File)
Thu, Dec 12, 10:47 PM
Unknown Object (File)
Tue, Dec 10, 12:38 AM
Unknown Object (File)
Mon, Dec 9, 5:38 PM
Unknown Object (File)
Fri, Dec 6, 10:12 AM
Unknown Object (File)
Thu, Nov 28, 5:32 AM
Unknown Object (File)
Tue, Nov 26, 9:52 PM
Unknown Object (File)
Tue, Nov 26, 3:31 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11042: Cluster documentation leads you slightly awry about "read only mode"
Commits
rPb352cae97de4: Don't stop on read-only mode for read-only storage workflows
Summary

Fixes T11042. Currently, all bin/storage workflows stop if cluster.read-only is set:

$ ./bin/storage adjust
Usage Exception: Phabricator is currently in read-only mode. Use --force to override this mode.

However, some of them (status, dump, databases, etc) are read-only anyway and safe to run. Don't prompt in these cases.

Test Plan
  • Set cluster.read-only to true.
  • Ran bin/storage dump, bin/storage status, etc. No longer received messages.

Diff Detail

Repository
rP Phabricator
Branch
rodump
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12360
Build 15638: Run Core Tests
Build 15637: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38483.May 30 2016, 3:34 PM
epriestley retitled this revision from to Don't stop on read-only mode for read-only storage workflows.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11042: Cluster documentation leads you slightly awry about "read only mode".
epriestley mentioned this in T11042: Cluster documentation leads you slightly awry about "read only mode".May 30 2016, 3:37 PM
chad accepted this revision.May 30 2016, 3:44 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 30 2016, 3:44 PM
Closed by commit rPb352cae97de4: Don't stop on read-only mode for read-only storage workflows (authored by epriestley, committed by epriestley). · Explain WhyMay 30 2016, 4:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38483

View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDatabasesWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementProbeWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementRenamespaceWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementShellWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementStatusWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...
Phabricator · Built by Phacility