Page MenuHomePhabricator
Differential D15987

Don't stop on read-only mode for read-only storage workflows
ClosedPublic
Actions

Authored by epriestley on May 30 2016, 3:34 PM.
Tags
None
Referenced Files
F15474178: D15987.diff
Sun, Apr 6, 5:53 AM
F15456464: D15987.id38486.diff
Sun, Mar 30, 9:54 AM
F15454306: D15987.id38483.diff
Sat, Mar 29, 5:51 PM
F15453352: D15987.id.diff
Sat, Mar 29, 11:06 AM
F15449470: D15987.diff
Fri, Mar 28, 10:31 AM
F15414656: D15987.id38483.diff
Thu, Mar 20, 1:49 AM
F15413077: D15987.id.diff
Wed, Mar 19, 4:57 PM
F15396314: D15987.id38486.diff
Sun, Mar 16, 1:25 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11042: Cluster documentation leads you slightly awry about "read only mode"
Commits
rPb352cae97de4: Don't stop on read-only mode for read-only storage workflows
Summary

Fixes T11042. Currently, all bin/storage workflows stop if cluster.read-only is set:

$ ./bin/storage adjust
Usage Exception: Phabricator is currently in read-only mode. Use --force to override this mode.

However, some of them (status, dump, databases, etc) are read-only anyway and safe to run. Don't prompt in these cases.

Test Plan
  • Set cluster.read-only to true.
  • Ran bin/storage dump, bin/storage status, etc. No longer received messages.

Diff Detail

Repository
rP Phabricator
Branch
rodump
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12360
Build 15638: Run Core Tests
Build 15637: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38483.May 30 2016, 3:34 PM
epriestley retitled this revision from to Don't stop on read-only mode for read-only storage workflows.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11042: Cluster documentation leads you slightly awry about "read only mode".
epriestley mentioned this in T11042: Cluster documentation leads you slightly awry about "read only mode".May 30 2016, 3:37 PM
chad accepted this revision.May 30 2016, 3:44 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 30 2016, 3:44 PM
Closed by commit rPb352cae97de4: Don't stop on read-only mode for read-only storage workflows (authored by epriestley, committed by epriestley). · Explain WhyMay 30 2016, 4:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38483

View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDatabasesWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementProbeWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementRenamespaceWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementShellWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementStatusWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...
Phabricator · Built by Phacility