Page MenuHomePhabricator

Don't stop on read-only mode for read-only storage workflows
ClosedPublic

Authored by epriestley on May 30 2016, 3:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 13, 12:16 PM
Unknown Object (File)
Jan 26 2024, 7:14 AM
Unknown Object (File)
Jan 22 2024, 5:21 PM
Unknown Object (File)
Dec 19 2023, 9:33 PM
Unknown Object (File)
Nov 30 2023, 5:08 AM
Unknown Object (File)
Nov 25 2023, 4:37 AM
Unknown Object (File)
Nov 18 2023, 6:37 AM
Unknown Object (File)
Nov 1 2023, 1:47 AM
Subscribers
None

Details

Summary

Fixes T11042. Currently, all bin/storage workflows stop if cluster.read-only is set:

$ ./bin/storage adjust
Usage Exception: Phabricator is currently in read-only mode. Use --force to override this mode.

However, some of them (status, dump, databases, etc) are read-only anyway and safe to run. Don't prompt in these cases.

Test Plan
  • Set cluster.read-only to true.
  • Ran bin/storage dump, bin/storage status, etc. No longer received messages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't stop on read-only mode for read-only storage workflows.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 30 2016, 3:44 PM
This revision was automatically updated to reflect the committed changes.