Page MenuHomePhabricator

Don't send mail to "uninteresting" auditors
ClosedPublic

Authored by epriestley on May 24 2016, 12:33 AM.
Tags
None
Referenced Files
F13156765: D15970.id38448.diff
Sun, May 5, 6:34 AM
Unknown Object (File)
Fri, May 3, 7:16 PM
Unknown Object (File)
Mon, Apr 22, 12:36 AM
Unknown Object (File)
Thu, Apr 11, 9:39 AM
Unknown Object (File)
Sat, Apr 6, 5:43 AM
Unknown Object (File)
Mar 31 2024, 8:03 PM
Unknown Object (File)
Mar 31 2024, 4:48 PM
Unknown Object (File)
Mar 31 2024, 4:48 PM
Subscribers
None

Details

Summary

Fixes T11017. We add packages as "uninteresting" auditors so that we can query commits by package later.

Until recently, this didn't matter because we didn't send mail to packages. But now we do, so stop mailing them when they don't actually need to do anything.

Test Plan
  • Made a commit to a file which was part of a package but which I owned (so it does not trigger auditing).
  • var_dump()'d mail "To:" PHIDs.
    • Before patch: included package.
    • After patch: no package.

Diff Detail

Repository
rP Phabricator
Branch
audit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12323
Build 15585: Run Core Tests
Build 15584: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Don't send mail to "uninteresting" auditors.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 24 2016, 12:54 AM
This revision was automatically updated to reflect the committed changes.