Page MenuHomePhabricator

When a revision is accepted but has open dependencies, show a note in the list UI
ClosedPublic

Authored by epriestley on May 16 2016, 7:03 PM.
Tags
None
Referenced Files
F15457628: D15930.diff
Sun, Mar 30, 5:27 PM
F15449115: D15930.id38358.diff
Fri, Mar 28, 8:28 AM
F15438330: D15930.id.diff
Wed, Mar 26, 12:11 AM
F15424316: D15930.diff
Sat, Mar 22, 9:29 PM
F15407517: D15930.diff
Tue, Mar 18, 6:02 PM
F15393471: D15930.id38358.diff
Sat, Mar 15, 9:00 PM
F15393143: D15930.id38358.diff
Sat, Mar 15, 7:57 PM
F15389399: D15930.diff
Sat, Mar 15, 5:12 AM
Subscribers
None

Details

Summary

Ref T10939. I don't think this is hugely important, but it doesn't clutter things up much and it's nice as a hint.

T4055 was the original request specifically asking for this. It wanted a separate bucket, but I think this use case isn't common/strong enough to justify that.

I would like to improve Differential's "X depends on Y" feature in the long term. We don't tend to use/need it much, but it could easily do a better and more automatic job of supporting review of a group of revisions.

Test Plan

Screen Shot 2016-05-16 at 11.53.15 AM.png (200×427 px, 25 KB)

Diff Detail

Repository
rP Phabricator
Branch
dash9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12231
Build 15449: Run Core Tests
Build 15448: arc lint + arc unit