Page MenuHomePhabricator

Fix a dashboard bucketing bug
ClosedPublic

Authored by epriestley on May 16 2016, 6:04 PM.
Tags
None
Referenced Files
F14352039: D15928.diff
Thu, Dec 19, 12:37 PM
Unknown Object (File)
Fri, Dec 13, 6:25 PM
Unknown Object (File)
Wed, Dec 4, 9:43 AM
Unknown Object (File)
Thu, Nov 21, 9:57 PM
Unknown Object (File)
Wed, Nov 20, 11:36 PM
Unknown Object (File)
Nov 18 2024, 1:46 PM
Unknown Object (File)
Nov 15 2024, 7:01 AM
Unknown Object (File)
Nov 13 2024, 12:09 PM
Subscribers
None

Details

Summary

Ref T10939. For various historical reasons, revision status is a numeric string. This comparison fails because it's (string) !== (int). Just use != so this will still work if we turn it into a real string in the future.

Test Plan

Tried a more specific test case locally, got better looking results in "Must Review" and "Should Review".

Diff Detail

Repository
rP Phabricator
Branch
dash7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12227
Build 15443: Run Core Tests
Build 15442: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a dashboard bucketing bug.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 16 2016, 6:05 PM
This revision was automatically updated to reflect the committed changes.