Page MenuHomePhabricator

Modernize "Responsible Users" tokenizer and add "exact(user)" token
ClosedPublic

Authored by epriestley on May 16 2016, 3:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 2:41 PM
Unknown Object (File)
Wed, Dec 11, 7:53 PM
Unknown Object (File)
Mon, Dec 9, 11:07 AM
Unknown Object (File)
Sat, Dec 7, 7:00 PM
Unknown Object (File)
Sat, Dec 7, 8:56 AM
Unknown Object (File)
Tue, Dec 3, 8:57 PM
Unknown Object (File)
Fri, Nov 29, 8:14 AM
Unknown Object (File)
Sun, Nov 24, 6:28 PM
Subscribers
None

Details

Summary

Ref T10939. Fixes T9263. Ref T4144.

First, this resolves users (converting users into all packages and projects they are responsible for) earlier, so bucketing can act on that data correctly. Previously, your own blocking reviews would appear in "Must Review" but your packages/projects' would not. Now, all of them will.

Second, this adds exact(username) to mean "just me, not my packages/projects". You can use this along with "Bucket: By Required Action" to create a personal view of "Active Revisions" if you'd like, and ignore all your project/package reviews.

Test Plan

Queried by "me" and "exact(me)", got reasonable looking results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.May 16 2016, 5:13 PM
This revision was automatically updated to reflect the committed changes.