Page MenuHomePhabricator

Change Differential revision buckets to focus on "next required action"
ClosedPublic

Authored by epriestley on May 16 2016, 3:17 PM.

Details

Summary

Ref T10939. Ref T4144. This splits the existing buckets ("Blocking Others", "Action Required", "Waiting on Others") into 6-7 buckets with a stronger focus on what the next action you need to take is.

See T10939#175423 for some discussion.

Overall, I think some of the root problems here are caused by reviewer laziness and shotgun review workflows (where a ton of people get automatically added to everything, probably unnecessarily), but these buckets haven't been updated since the introduction of blocking reviewers or project/package reviewers and I think splitting the 3 buckets into 6 buckets isn't unreasonable, even though it's kind of a lot of buckets and the root problem here is approximately "I want to ignore a bunch of stuff on my dashboard".

I didn't remove the old bucketing code yet since it's still in use on the default homepage.

This also isn't quite right until I fix the tokenizer to work properly, since it won't bucket project/package reviewers accurately.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 38341.May 16 2016, 3:17 PM
epriestley retitled this revision from to Change Differential revision buckets to focus on "next required action".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.May 16 2016, 3:57 PM
chad edited edge metadata.

Yeah the only thing I can think of to possibly combat over-zealous reviews is to build something just like "too much mail". "Too many reviews" could list why you're getting added (if programatically) and give you means of getting out of them.

This revision is now accepted and ready to land.May 16 2016, 3:57 PM

Next couple changes might help with that somewhat:

  • D15925 lets you build a "Personal" dashboard if you want, with only your direct stuff.
  • D15926 highlights the reviewers you're responsible for, so it should be more clear why something is in one of your buckets at a glance.
This revision was automatically updated to reflect the committed changes.