Page MenuHomePhabricator
Differential D15918

Don't trigger "Auto Review" if the author is already an owner; document "Auto Review"
ClosedPublic
Actions

Authored by epriestley on May 13 2016, 6:49 PM.
Tags
None
Referenced Files
F15450743: D15918.id.diff
Fri, Mar 28, 5:55 PM
F15445347: D15918.diff
Thu, Mar 27, 1:32 PM
F15438649: D15918.diff
Wed, Mar 26, 2:19 AM
F15388495: D15918.id38322.diff
Sat, Mar 15, 3:55 AM
F15360326: D15918.id38334.diff
Tue, Mar 11, 8:15 AM
Unknown Object (File)
Sun, Mar 2, 10:47 AM
Unknown Object (File)
Sun, Mar 2, 10:19 AM
Unknown Object (File)
Sun, Mar 2, 10:19 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10939: Support for OWNERS files
Commits
rPc9365e48d8e4: Don't trigger "Auto Review" if the author is already an owner; document "Auto…
Summary

Ref T10939. If you already own a package, don't trigger the subscribe/review rules.

Document how these rules work.

Test Plan
  • Read documentation.
  • Removed reviewers, updated a revision, got autoreviewed.
  • Joined package.
  • Removed reveiwers, updated a revision, no more autoreview.

Diff Detail

Repository
rP Phabricator
Branch
owners11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12194
Build 15398: Run Core Tests
Build 15397: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38322.May 13 2016, 6:49 PM
epriestley retitled this revision from to Don't trigger "Auto Review" if the author is already an owner; document "Auto Review".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10939: Support for OWNERS files.
epriestley mentioned this in T10939: Support for OWNERS files.May 13 2016, 6:53 PM
chad accepted this revision.May 13 2016, 7:51 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 7:51 PM
Closed by commit rPc9365e48d8e4: Don't trigger "Auto Review" if the author is already an owner; document "Auto… (authored by epriestley, committed by epriestley). · Explain WhyMay 14 2016, 12:24 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T5000: Using Differential with plain Git, without requiring Arc.May 20 2016, 11:04 PM

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
21 lines
docs/
user/
userguide/
26 lines

Diff 38322

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/docs/user/userguide/owners.diviner

Loading...
Phabricator · Built by Phacility