Page MenuHomePhabricator
Differential D15914

Allow packages to be added as revision reviewers via the UI
ClosedPublic
Actions

Authored by epriestley on May 13 2016, 5:54 PM.
Tags
None
Referenced Files
F13059678: D15914.diff
Fri, Apr 19, 4:40 PM
Unknown Object (File)
Mon, Apr 15, 10:08 AM
Unknown Object (File)
Fri, Apr 12, 8:09 PM
Unknown Object (File)
Wed, Apr 10, 12:10 AM
Unknown Object (File)
Wed, Apr 3, 3:07 PM
Unknown Object (File)
Fri, Mar 29, 1:35 PM
Unknown Object (File)
Fri, Mar 29, 10:32 AM
Unknown Object (File)
Fri, Mar 29, 10:32 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10939: Support for OWNERS files
Commits
rP70ddb1c45fe4: Allow packages to be added as revision reviewers via the UI
Summary

Ref T10939. This lets you add packages as reviewers manually.

"Project Reviewers" now lists both projects and packages. I have renamed this to "Coalition Reviewers" but that's probably horrible and confusing. I'm not sure "Group Reviewers" is much better.

Test Plan
  • Added a package as a reviewer manually.
  • Joined it, got authority over it.
  • Saw the review on my dashboard.
  • Accepted the revision, got authority extended to the package review.

Screen Shot 2016-05-13 at 10.50.44 AM.png (195×408 px, 21 KB)

Screen Shot 2016-05-13 at 10.51.09 AM.png (202×547 px, 24 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38318.May 13 2016, 5:54 PM
epriestley retitled this revision from to Allow packages to be added as revision reviewers via the UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10939: Support for OWNERS files.
chad added inline comments.May 13 2016, 7:35 PM
src/applications/differential/customfield/DifferentialProjectReviewersField.php
11

images.jpg (204×240 px, 5 KB)

chad edited edge metadata.May 13 2016, 7:37 PM

Group seems slightly better. Or maybe team?

chad accepted this revision.May 13 2016, 7:37 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 7:37 PM
Closed by commit rP70ddb1c45fe4: Allow packages to be added as revision reviewers via the UI (authored by epriestley, committed by epriestley). · Explain WhyMay 14 2016, 12:20 AM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.May 14 2016, 12:21 AM

I did "Group Reviewers". ¯\_(ツ)_/¯

epriestley mentioned this in T10939: Support for OWNERS files.May 14 2016, 1:02 AM
epriestley mentioned this in T5000: Using Differential with plain Git, without requiring Arc.May 20 2016, 11:04 PM

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
customfield/
2 lines
2 lines

Diff 38330

View Options

src/applications/differential/customfield/DifferentialProjectReviewersField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialReviewersField.php

Loading...
Phabricator · Built by Phacility