Page MenuHomePhabricator
Differential D15904

Allow users to set a line-height in their monospaced font preference
ClosedPublic
Actions

Authored by epriestley on May 12 2016, 11:42 PM.
Tags
None
Referenced Files
F15447088: D15904.diff
Thu, Mar 27, 9:48 PM
F15412693: D15904.diff
Wed, Mar 19, 2:26 PM
F15391044: D15904.id38304.diff
Sat, Mar 15, 7:56 AM
F15283559: D15904.diff
Mar 4 2025, 7:52 AM
Unknown Object (File)
Feb 9 2025, 1:36 AM
Unknown Object (File)
Feb 9 2025, 1:36 AM
Unknown Object (File)
Feb 9 2025, 1:36 AM
Unknown Object (File)
Feb 9 2025, 1:36 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10959: Hard-coded diff line height interacts poorly with large custom font sizes
Commits
rP8cdafb003250: Allow users to set a line-height in their monospaced font preference
Summary

Ref T10959. This does not fix the problem because the .differential-diff td rule is still stronger, but it does let you choose a more compact or breezy style for remarkup blocks and pastes.

Test Plan
  • Set font to 24px / 48px impact.
  • Viewed a paste, saw lovely readable text.
  • Viewed an inline code block which was very easy on the eyes.

Screen Shot 2016-05-12 at 4.40.12 PM.png (844×651 px, 67 KB)

Diff Detail

Repository
rP Phabricator
Branch
mono1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12176
Build 15366: Run Core Tests
Build 15365: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38304.May 12 2016, 11:42 PM
epriestley retitled this revision from to Allow users to set a line-height in their monospaced font preference.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10959: Hard-coded diff line height interacts poorly with large custom font sizes.
chad accepted this revision.May 13 2016, 3:03 AM
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 3:03 AM
Closed by commit rP8cdafb003250: Allow users to set a line-height in their monospaced font preference (authored by epriestley, committed by epriestley). · Explain WhyMay 13 2016, 12:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
settings/
storage/
2 lines

Diff 38304

View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...
Phabricator · Built by Phacility