Page MenuHomePhabricator

In Subversion, show "svn checkout <uri> <directory>" in Diffusion
ClosedPublic

Authored by epriestley on May 11 2016, 2:27 PM.
Tags
None
Referenced Files
F14020820: D15888.diff
Wed, Nov 6, 2:58 AM
F13983469: D15888.diff
Sun, Oct 20, 6:43 AM
Unknown Object (File)
Oct 10 2024, 3:29 AM
Unknown Object (File)
Oct 3 2024, 1:32 AM
Unknown Object (File)
Sep 20 2024, 9:27 PM
Unknown Object (File)
Sep 19 2024, 8:49 AM
Unknown Object (File)
Sep 18 2024, 1:22 PM
Unknown Object (File)
Sep 15 2024, 6:37 PM
Subscribers
None

Details

Summary

Ref T10923. The old behavior was to show a full command in SVN, Mercurial, and Git, like this:

  • git clone <uri>
  • hg clone <uri>
  • svn checkout <uri> <directory>

In Git and Mercurial, the <uri> ends in something like /nice-repository-name.git so the default directory it creates is called nice-repository-name/.

In Subversion, we don't (and can't easily) do that for various reasons so we provide an explicit <directory> with the nice name.

In the update, I've changed things to just show the URI. I often found that I wanted the URI alone, not the whole clone command (for example, to fetch, remote-add, etc). This is also consistent with GitHub. Because we have nice URIs for Git and Mercurial, git clone <uri> has good behavior.

In Subversion, svn checkout <uri> has bad beahvior (you get a directory named 47/ or whatever). So continue showing the whole command there.

We can possibly tailor this after T4245 finishes up and we get access to /source/nice-repository-name/ URIs.

Test Plan
  • Viewed a Subversion repository, saw a full command.
  • Viewed a Git repository, saw only a clone URI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to In Subversion, show "svn checkout <uri> <directory>" in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 11 2016, 4:16 PM
This revision was automatically updated to reflect the committed changes.