Differential D15877

When observing a repository, switch to "importing" mode on a large discovery in an empty repository
ClosedPublic
Actions

Authored by epriestley on May 10 2016, 2:05 PM.

Details

Reviewers

chad

Maniphest Tasks

T9554: Trigger "import" heuristics for imported repositories
T10923: Diffusion API/URI Errata

Commits

rP71a97d8af56b: When observing a repository, switch to "importing" mode on a large discovery…

Summary

Ref T10923. Fixes T9554.

When hosting a repository, we currently have a heuristic that tries to detect when you're doing an initial import: if you push more than 7 commits to an empty repository, it counts as an import and we disable mail/feed/etc.

Do something similar for observed repositories: if the repository is empty and we discover more than 7 commits, switch to import mode until we catch up.

This should align behavior with user expectation more often when juggling hosted vs imported repositories.

Test Plan

Created a new hosted repository.
Activated it and allowed it to fully import.
Added an "Observe URI".
Saw it automatically drop into "Importing" mode until the import completed.
Swapped it back to hosted mode.

Diff Detail

Repository

rP Phabricator

Branch

dxdoc12

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12118
Build 15278: Run Core Tests
Build 15277: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	81 ms	PhabricatorChangeParserTestCase::Unknown Unit Message ("") EXCEPTION (PhutilAggregateException): Multiple exceptions were raised during test execution. - Execution: LiskEphemeralObjectException: - Shutdown: Exception: Process exited with an open transaction! The transaction will be implicitly rolled back. Calls to openTransaction() must always be paired with a call to saveTransaction() or killTransaction().
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("") 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 2 assertions passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 3 assertions passed.
		View Full Test Results (1 Failed · 335 Passed)

Event Timeline

epriestley updated this revision to Diff 38243.May 10 2016, 2:05 PM

epriestley retitled this revision from to When observing a repository, switch to "importing" mode on a large discovery in an empty repository.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10923: Diffusion API/URI Errata, T9554: Trigger "import" heuristics for imported repositories.

chad accepted this revision.May 11 2016, 2:56 AM

chad edited edge metadata.

This revision is now accepted and ready to land.May 11 2016, 2:56 AM

Ah, I think this caused the bad unit test in the rest of the series -- specifically, in the unit tests we create a repository and mark it ephemeral (to prevent anything from updating it), but this now causes it to update.

There's no real reason to mark it ephemeral (this was just a sanity check sort of thing, I believe), so I'll just remove that, which should fix this and all subsequent changes.