Page MenuHomePhabricator

Update redirect/cancel URIs for repository dialogs
ClosedPublic

Authored by epriestley on May 9 2016, 2:07 PM.
Tags
None
Referenced Files
F15459544: D15867.id.diff
Mon, Mar 31, 1:55 PM
F15447567: D15867.diff
Fri, Mar 28, 12:39 AM
F15423022: D15867.id.diff
Sat, Mar 22, 12:12 PM
F15422426: D15867.id38221.diff
Sat, Mar 22, 8:12 AM
Unknown Object (File)
Mar 3 2025, 8:06 PM
Unknown Object (File)
Mar 1 2025, 4:29 AM
Unknown Object (File)
Mar 1 2025, 2:10 AM
Unknown Object (File)
Feb 26 2025, 12:39 PM
Subscribers
None

Details

Summary

Ref T10923. Some of the dialogs ("Deactivate Repository", "Test Automation", etc.) had cancel or redirect URIs which I missed originally.

Go through them and make sure they all point to the right places.

Also removed one unused controller which I missed the first time around.

Test Plan
  • Opened all these dialogs in a new tab with Command-Click.
  • Clicked every "cancel" and "submit" button on all of these dialogs.
  • Got consistently sent to the place I came from.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Update redirect/cancel URIs for repository dialogs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 9 2016, 3:03 PM
This revision was automatically updated to reflect the committed changes.