Differential D15866

Put "Push Policy" last in Diffusion, make editing Spaces work
ClosedPublic
Actions

Authored by epriestley on May 9 2016, 1:31 PM.

Details

Reviewers

chad

Maniphest Tasks

T10923: Diffusion API/URI Errata

Commits

rP846eec7563d8: Put "Push Policy" last in Diffusion, make editing Spaces work

Summary

Ref T10923.

The "Policy" edit form currently goes "Push, View, Edit". Reorder the defaults to "View, Edit, Push".
Editing Spaces doesn't currently work: the element appears in the UI, but isn't actually processed when handling transactions. Make that work.

Test Plan

Edited a repository policies, saw "View, Edit, Push".
Moved a repository between Spaces.

Diff Detail

Repository

rP Phabricator

Branch

dxdoc1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12094
Build 15240: Run Core Tests
Build 15239: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38219.May 9 2016, 1:31 PM

epriestley retitled this revision from to Put "Push Policy" last in Diffusion, make editing Spaces work.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10923: Diffusion API/URI Errata.

chad accepted this revision.May 9 2016, 1:33 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 9 2016, 1:33 PM

Closed by commit rP846eec7563d8: Put "Push Policy" last in Diffusion, make editing Spaces work (authored by epriestley, committed by epriestley). · Explain WhyMay 9 2016, 1:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

editor/

DiffusionRepositoryEditEngine.php

29 lines

management/

DiffusionRepositoryPoliciesManagementPanel.php

1 line

Diff 38219

View Options

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php