Page MenuHomePhabricator
Differential D15818

Prefer pip to easy_install
ClosedPublic
Actions

Authored by eadler on Apr 29 2016, 4:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 3:35 AM
Unknown Object (File)
Wed, Apr 24, 3:35 AM
Unknown Object (File)
Wed, Apr 24, 3:35 AM
Unknown Object (File)
Wed, Apr 24, 3:35 AM
Unknown Object (File)
Wed, Apr 24, 3:35 AM
Unknown Object (File)
Fri, Apr 19, 4:36 PM
Unknown Object (File)
Thu, Apr 11, 9:00 AM
Unknown Object (File)
Sun, Mar 31, 6:47 PM
View All Files
Subscribers
avivey
Korvin

Details

Reviewers
epriestley
avivey
tjstum
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T10038: Plan the mid-term pathway for unit-test/linter bindings
T10892: Recommend pip instead of easy_install for Python linters
Commits
rARCc58f1b9a2507: Prefer pip to easy_install
Summary

Prefer pip to easy_install
also fixes incorrect install instructions for closure linters

Fixes T10892
Ref T10038

Test Plan

inspection

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

eadler updated this revision to Diff 38100.Apr 29 2016, 4:57 AM
eadler retitled this revision from to Prefer pip to easy_install.
eadler updated this object.
eadler edited the test plan for this revision. (Show Details)
eadler added reviewers: epriestley, tjstum.
eadler added tasks: T10892: Recommend pip instead of easy_install for Python linters, T10038: Plan the mid-term pathway for unit-test/linter bindings.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 29 2016, 4:57 AM
Herald added a subscriber: Korvin. · View Herald Transcript
eadler updated this revision to Diff 38101.Apr 29 2016, 4:59 AM
eadler edited edge metadata.

reupload with fix

avivey accepted this revision.Apr 29 2016, 5:06 AM
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

lgtm

epriestley accepted this revision.Apr 29 2016, 12:18 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 29 2016, 12:18 PM
tjstum accepted this revision.Apr 29 2016, 2:15 PM
tjstum edited edge metadata.

Awesome, thanks!

Closed by commit rARCc58f1b9a2507: Prefer pip to easy_install (authored by eadler, committed by eadler). · Explain WhyApr 29 2016, 3:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38111

View Options

src/lint/linter/ArcanistClosureLinter.php

Loading...
View Options

src/lint/linter/ArcanistFlake8Linter.php

Loading...
View Options

src/lint/linter/ArcanistPEP8Linter.php

Loading...
Phabricator · Built by Phacility