Page MenuHomePhabricator

Don't retry queries on connections holding global locks
ClosedPublic

Authored by epriestley on Apr 24 2016, 3:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 6, 1:30 PM
Unknown Object (File)
Fri, Jul 29, 12:02 AM
Unknown Object (File)
Tue, Jul 19, 9:42 PM
Unknown Object (File)
Jul 9 2022, 9:33 AM
Unknown Object (File)
Jul 9 2022, 9:33 AM
Unknown Object (File)
Jul 9 2022, 9:33 AM
Unknown Object (File)
Jul 9 2022, 9:33 AM
Unknown Object (File)
Jun 26 2022, 10:54 AM
Subscribers
None

Details

Summary

Ref T10860. Currently, if we lose a connection that is holding a MySQL global lock, we may retry the query automatically.

Instead, we should abort, just like we do if we were in the middle of a transaction. Otherwise, code may still think it has the lock and do unsafe things.

Test Plan

See next revision.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't retry queries on connections holding global locks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 24 2016, 4:09 PM
This revision was automatically updated to reflect the committed changes.