Page MenuHomePhabricator
Differential D15754

Consolidate handling of SSH usernames
ClosedPublic
Actions

Authored by epriestley on Apr 19 2016, 1:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 4:31 PM
Unknown Object (File)
Thu, Apr 18, 5:35 AM
Unknown Object (File)
Mon, Apr 8, 11:46 PM
Unknown Object (File)
Apr 2 2024, 7:59 PM
Unknown Object (File)
Apr 1 2024, 3:14 AM
Unknown Object (File)
Mar 31 2024, 4:41 PM
Unknown Object (File)
Mar 31 2024, 4:41 PM
Unknown Object (File)
Mar 27 2024, 2:34 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4292: Implement repository replication
Commits
rP0db6eaca4173: Consolidate handling of SSH usernames
Summary

Ref T4292. This consolidates code for figuring out which user we should connect to hosts with.

Also narrows a lock window.

Test Plan

Browsed Diffusion, pulled and pushed through an SSH proxy.

Diff Detail

Repository
rP Phabricator
Branch
rlock4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11834
Build 14850: Run Core Tests
Build 14849: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37962.Apr 19 2016, 1:03 PM
epriestley retitled this revision from to Consolidate handling of SSH usernames.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4292: Implement repository replication.
chad accepted this revision.Apr 19 2016, 5:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 19 2016, 5:23 PM
Closed by commit rP0db6eaca4173: Consolidate handling of SSH usernames (authored by epriestley, committed by epriestley). · Explain WhyApr 19 2016, 8:04 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 19 2016, 9:29 PM
epriestley mentioned this in T13529: Phacility domain rename errata and SSH user identity.May 12 2020, 6:20 PM

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
util/
18 lines
diffusion/
ssh/
15 lines
repository/
storage/
11 lines
2 lines

Diff 37962

View Options

src/applications/almanac/util/AlmanacKeys.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionSSHWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryURI.php

Loading...
Phabricator · Built by Phacility