Page MenuHomePhabricator

Improve performance of `arc branch` in Git with many branches
ClosedPublic

Authored by epriestley on Apr 16 2016, 4:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 13, 8:28 PM
Unknown Object (File)
Mon, Aug 8, 12:12 PM
Unknown Object (File)
Wed, Aug 3, 1:19 PM
Unknown Object (File)
Sun, Jul 24, 11:16 PM
Unknown Object (File)
Jul 14 2022, 5:55 AM
Unknown Object (File)
Jul 6 2022, 9:58 PM
Unknown Object (File)
Jun 25 2022, 11:52 AM
Unknown Object (File)
Jun 9 2022, 8:04 PM
Subscribers
None

Details

Summary

This is mostly just a personal quality-of-life fix. I run this command fairly often and having it return a little faster is nice.

This replaces a git show for each individual branch with a big git for-each-ref which we were already running anyway. This is quite a bit faster.

This command also occasionally hangs or segfaults for me while executing the huge pile of subprocesses. This is unreliable to reproduce, probably some bug in some PHP extension I have, and likely hard to narrow down, and this approach is better in every way anyway.

Test Plan
  • Ran arc branch in Git, observed faster output (in my phabricator/, about 2000ms -> 1200ms).
  • Ran arc feature in Mercurial.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve performance of `arc branch` in Git with many branches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 16 2016, 5:01 PM
This revision was automatically updated to reflect the committed changes.