Page MenuHomePhabricator

Improve performance of `arc branch` in Git with many branches
ClosedPublic

Authored by epriestley on Apr 16 2016, 4:43 PM.

Details

Summary

This is mostly just a personal quality-of-life fix. I run this command fairly often and having it return a little faster is nice.

This replaces a git show for each individual branch with a big git for-each-ref which we were already running anyway. This is quite a bit faster.

This command also occasionally hangs or segfaults for me while executing the huge pile of subprocesses. This is unreliable to reproduce, probably some bug in some PHP extension I have, and likely hard to narrow down, and this approach is better in every way anyway.

Test Plan
  • Ran arc branch in Git, observed faster output (in my phabricator/, about 2000ms -> 1200ms).
  • Ran arc feature in Mercurial.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 37917.Apr 16 2016, 4:43 PM
epriestley retitled this revision from to Improve performance of `arc branch` in Git with many branches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Apr 16 2016, 5:01 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 16 2016, 5:01 PM
This revision was automatically updated to reflect the committed changes.