Page MenuHomePhabricator

Improve performance of `arc branch` in Git with many branches
ClosedPublic

Authored by epriestley on Apr 16 2016, 4:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 7:41 PM
Unknown Object (File)
Wed, Nov 20, 8:53 AM
Unknown Object (File)
Tue, Nov 19, 10:56 AM
Unknown Object (File)
Sat, Nov 16, 7:44 AM
Unknown Object (File)
Tue, Nov 12, 5:30 AM
Unknown Object (File)
Thu, Nov 7, 7:28 PM
Unknown Object (File)
Thu, Oct 24, 4:21 PM
Unknown Object (File)
Oct 20 2024, 12:51 AM
Subscribers
None

Details

Summary

This is mostly just a personal quality-of-life fix. I run this command fairly often and having it return a little faster is nice.

This replaces a git show for each individual branch with a big git for-each-ref which we were already running anyway. This is quite a bit faster.

This command also occasionally hangs or segfaults for me while executing the huge pile of subprocesses. This is unreliable to reproduce, probably some bug in some PHP extension I have, and likely hard to narrow down, and this approach is better in every way anyway.

Test Plan
  • Ran arc branch in Git, observed faster output (in my phabricator/, about 2000ms -> 1200ms).
  • Ran arc feature in Mercurial.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve performance of `arc branch` in Git with many branches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 16 2016, 5:01 PM
This revision was automatically updated to reflect the committed changes.