Support relative links in Phriction
ClosedPublic
Actions

Authored by hach-que on Apr 16 2016, 2:23 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7691: Relative wiki links

Commits

rPdd1023e5a8f8: Support relative links in Phriction

Summary

Resolves T7691. This turned out more complex than I really wanted, mainly because I needed to feed the slug information through to both the document renderer and the preview window that appears in the edit controller.

After this change, you can now create relative links in Phriction by doing [[ ./../some/relative/path ]]. Relative paths aren't handled anywhere else (they'll still render, but the dots are turned into a literal 'dot' as per existing behaviour).

Test Plan

Created some Phriction documents with relative links, saw them all link correctly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hach-que updated this revision to Diff 37910.Apr 16 2016, 2:23 AM

hach-que retitled this revision from to Support relative links in Phriction.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T7691: Relative wiki links.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 16 2016, 2:23 AM

Herald added a subscriber: Korvin. · View Herald Transcript

@epriestley Passing the slug through to Remarkup like this feels like a bit of a kludge; especially because the preview window requires making a new preview controller. I'm not sure how to proceed with this?

By the end of this we should update the docs, too.

src/applications/phriction/markup/PhrictionRemarkupRule.php
20	This could go elsewhere, but `../x/y` is probably fine to trigger this too.
36	Consider structuring this more explicitly to improve clarity.

This revision is now accepted and ready to land.Apr 16 2016, 2:52 AM

epriestley awarded a token.Apr 16 2016, 2:52 AM

Oh, and I think it's fine to have the new controller / context thing. It's a little kludgey but there aren't many (any?) other cases of things like this right now so it's probably not worth trying to build something fancy to de-kludge it.

hach-que added inline comments.Apr 16 2016, 3:00 AM

src/applications/phriction/markup/PhrictionRemarkupRule.php
36	I think the linter ate the newlines here. I'll throw in a comment to stop it condensing this block (but also explain the treatment of `.`).

hach-que added inline comments.Apr 16 2016, 3:04 AM

src/applications/phriction/markup/PhrictionRemarkupRule.php
20	I'll leave this as-is for now and we can update it later if people expect it to work (because easier to add a Remarkup rule later than remove them).