Page MenuHomePhabricator

Fix parsing of anchors in Phriction document link syntax
ClosedPublic

Authored by epriestley on Jun 8 2016, 8:13 PM.
Tags
None
Referenced Files
F13481362: D16083.diff
Fri, Jul 19, 10:41 AM
F13456360: D16083.id38696.diff
Sun, Jul 14, 1:53 PM
F13453438: D16083.diff
Sun, Jul 14, 12:11 AM
F13418660: D16083.diff
Mon, Jul 8, 1:28 AM
F13400719: D16083.diff
Thu, Jul 4, 12:01 PM
F13394979: D16083.id.diff
Wed, Jul 3, 12:06 PM
F13388384: D16083.id38696.diff
Mon, Jul 1, 11:32 AM
F13384222: D16083.id38697.diff
Sun, Jun 30, 2:52 PM
Subscribers
None

Details

Summary

Ref T4280. At some point (probably D15732) we started getting anchor parsing wrong. Just pop the anchor off before doing all the logic, then put it back on at the end.

Test Plan

Tested various forms like:

[[ x ]]
[[ x | z ]]
[[ x#y | z ]]
[[ ./x#y | z ]]

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix parsing of anchors in Phriction document link syntax.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2016, 8:13 PM
This revision was automatically updated to reflect the committed changes.